Issue 10950007: Fix generating html_dart2js.dart and html_dartium.dart files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10950007: Fix generating html_dart2js.dart and html_dartium.dart files. (Closed)

Created:
8 years, 3 months ago by podivilov

Modified:
8 years, 3 months ago

Reviewers:
vsm, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix generating html_dart2js.dart and html_dartium.dart files. R=efortuna@google.com,vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=12506

Patch Set 1 #

Created: 8 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -48 lines)			Patch
M	lib/html/scripts/dartdomgenerator.py	View	3 chunks	+24 lines, -23 lines	0 comments	Download
M	lib/html/scripts/systembase.py	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	lib/html/scripts/systemhtml.py	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	lib/html/scripts/systemnative.py	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/html/templates/html/dart2js/html_dart2js.darttemplate	View	1 chunk	+21 lines, -21 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

vsm

Hi Pavel, can you comment on what exactly is broken? Is this just cleanup?

8 years, 3 months ago (2012-09-18 15:49:02 UTC) #2

Emily Fortuna

lgtm. Thanks Pavel! @Vijay, with the changes in this refactoring CL: https://codereview.chromium.org/10917264/ html_dart2js.dart from being ...

8 years, 3 months ago (2012-09-18 16:51:51 UTC) #3

podivilov

8 years, 3 months ago (2012-09-18 17:16:58 UTC) #5

On 2012/09/18 15:49:02, vsm wrote:
> Hi Pavel, can you comment on what exactly is broken?  Is this just cleanup?

Hi Vijay!

GenerateSingleFile has some hard-coded paths, so after moving generated files it
stopped to update html_dart2js.dart file properly. I didn't expect any changes
in html_dart2js.dart anyway, so it came unnoticed.

Also, paths to html/src/*.dart files in html_dart2js.darttemplate were
incorrect, but I didn't noticed that as well due to the bug in
GenerateSingleFile.

Expand Messages | Collapse Messages