Issue 1094993002: Fix tests and analysis warnings and release 0.12.0-beta.9.

Issue 1094993002: Fix tests and analysis warnings and release 0.12.0-beta.9. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix tests and analysis warnings and release 0.12.0-beta.9. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/5a9a8d8e3b1d5aa90d2785cd09512651fa184a69

Patch Set 2 : Code review changes #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -10 lines)			Patch
M	lib/src/runner/loader.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/runner/browser/chrome_test.dart	View	3 chunks	+8 lines, -2 lines	0 comments	Download
M	test/runner/browser/content_shell_test.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	test/runner/browser/dartium_test.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	test/runner/browser/firefox_test.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	test/runner/browser/phantom_js_test.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	test/runner/browser/safari_test.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

LGTM modulo oops https://codereview.chromium.org/1094993002/diff/1/lib/src/runner/browser/chrome.dart File lib/src/runner/browser/chrome.dart (right): https://codereview.chromium.org/1094993002/diff/1/lib/src/runner/browser/chrome.dart#newcode65 lib/src/runner/browser/chrome.dart:65: process.stderr.listen(stderr.add); oops?

5 years, 8 months ago (2015-04-18 00:33:43 UTC) #2

nweiz

https://codereview.chromium.org/1094993002/diff/1/lib/src/runner/browser/chrome.dart File lib/src/runner/browser/chrome.dart (right): https://codereview.chromium.org/1094993002/diff/1/lib/src/runner/browser/chrome.dart#newcode65 lib/src/runner/browser/chrome.dart:65: process.stderr.listen(stderr.add); On 2015/04/18 00:33:43, kevmoo wrote: > oops? Done.

5 years, 8 months ago (2015-04-18 00:36:11 UTC) #4

nweiz

5 years, 8 months ago (2015-04-18 00:36:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
5a9a8d8e3b1d5aa90d2785cd09512651fa184a69 (presubmit successful).

Expand Messages | Collapse Messages