Better hints for await in non-async functions

Better hints for await in non-async functions

BUG=23234
R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45256

[Siggi Cherem (dart-lang), 2015-04-17 17:29:18]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2015-04-17 17:29:22]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2015-04-17 17:30:15]

sigmund@google.com changed reviewers:
+ johnniwinther@google.com

[Siggi Cherem (dart-lang), 2015-04-17 17:35:23]

Patchset #1 (id:40001) has been deleted

[Johnni Winther, 2015-04-17 18:01:31]

lgtm

https://codereview.chromium.org/1094903002/diff/60001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1094903002/diff/60001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:2326: kind =
MessageKind.CANNOT_RESOLVE_AWAIT;
Due to localization (if ever needed) we try not to create message wording
dynamically (we only insert names from the codes or word from Dart language
terminology). Use a specialized message instead.

[Siggi Cherem (dart-lang), 2015-04-17 20:58:51]

thanks

https://codereview.chromium.org/1094903002/diff/60001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1094903002/diff/60001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:2326: kind =
MessageKind.CANNOT_RESOLVE_AWAIT;
On 2015/04/17 18:01:31, Johnni Winther wrote:
> Due to localization (if ever needed) we try not to create message wording
> dynamically (we only insert names from the codes or word from Dart language
> terminology). Use a specialized message instead.

Ah, I see. I went ahead and divided the message in two specialized messages for
each case, so we don't have any text included here.

[Siggi Cherem (dart-lang), 2015-04-17 20:59:07]

Committed patchset #2 (id:80001) manually as 45256 (presubmit successful).