Issue 10949020: Reapply "Initial implementation of sparse conditional constant propagation."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10949020: Reapply "Initial implementation of sparse conditional constant propagation." (Closed)

Created:
8 years, 3 months ago by Kevin Millikin (Google)

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider, zerny-google, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Initial implementation of sparse conditional constant propagation." With a fix for compilation on Mac. GrowableArray is DISALLOW_COPY_AND_ASSIGN, so we can't create a temporary one to be ignored and have to pass one in to be ignored. R=fschneider@google.com,zerny@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12561

Patch Set 1 #

Patch Set 2 : Rebase to HEAD. #

Total comments: 3

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1116 lines, -254 lines)			Patch
M	runtime/lib/integers.cc	View		14 chunks	+14 lines, -181 lines	0 comments	Download
M	runtime/vm/compiler.cc	View		2 chunks	+6 lines, -7 lines	3 comments	Download
M	runtime/vm/flow_graph.h	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	1	12 chunks	+30 lines, -35 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View		1 chunk	+60 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	2 chunks	+697 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	13 chunks	+42 lines, -19 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	6 chunks	+87 lines, -8 lines	0 comments	Download
M	runtime/vm/object.h	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View		2 chunks	+167 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

8 years, 3 months ago (2012-09-19 22:20:18 UTC) #3

https://codereview.chromium.org/10949020/diff/3001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/10949020/diff/3001/runtime/vm/compiler.cc#new...
runtime/vm/compiler.cc:38: DEFINE_FLAG(bool, cp, true,
This is a perfect example of a bad flag name. I am changing this to be something
that cannot be mistaken for copy.

https://codereview.chromium.org/10949020/diff/3001/runtime/vm/compiler.cc#new...
runtime/vm/compiler.cc:40: DEFINE_FLAG(bool, cse, true, "Do common subexpression
elimination.");
ditto

https://codereview.chromium.org/10949020/diff/3001/runtime/vm/compiler.cc#new...
runtime/vm/compiler.cc:41: DEFINE_FLAG(bool, licm, true, "Do loop invariant code
motion.");
ditto

Expand Messages | Collapse Messages