Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 10949003: Revert r12491 (Closed)

Created:
8 years, 3 months ago by ricow1
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org, karlklose
Visibility:
Public.

Description

Revert r12491 This is causing checked mode failures on the buildbot. Committed: https://code.google.com/p/dart/source/detail?r=12500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -195 lines) Patch
M compiler/java/com/google/dart/compiler/DartCompiler.java View 1 chunk +7 lines, -0 lines 0 comments Download
M lib/compiler/implementation/compiler.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/compiler/implementation/enqueue.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M lib/compiler/implementation/js_backend/emitter.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M lib/compiler/implementation/lib/core_patch.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M lib/compiler/implementation/lib/interceptors.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 1 chunk +0 lines, -22 lines 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 3 chunks +18 lines, -46 lines 0 comments Download
M lib/compiler/implementation/ssa/ssa.dart View 1 chunk +0 lines, -56 lines 0 comments Download
M lib/compiler/implementation/world.dart View 1 chunk +1 line, -3 lines 0 comments Download
M lib/core/object.dart View 1 chunk +0 lines, -4 lines 0 comments Download
D tests/language/first_class_types.dart View 1 chunk +0 lines, -34 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
8 years, 3 months ago (2012-09-18 14:35:31 UTC) #1
ricow1
TBR
8 years, 3 months ago (2012-09-18 14:40:06 UTC) #2
ricow1
This was Karls, so CC him
8 years, 3 months ago (2012-09-18 14:42:24 UTC) #3
ahe
8 years, 3 months ago (2012-09-18 14:43:16 UTC) #4
LGTM :-(

Powered by Google App Engine
This is Rietveld 408576698