Issue 10949002: Update test expectations some more.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10949002: Update test expectations some more. (Closed)

Created:
8 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 3 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update test expectations some more. TBR=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=12466

Patch Set 1 #

Total comments: 4

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	tests/co19/co19-runtime.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	tests/language/language.status	View		6 chunks	+11 lines, -1 line	4 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

8 years, 3 months ago (2012-09-18 07:11:57 UTC) #1

LGTM

https://codereview.chromium.org/10949002/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/10949002/diff/1/tests/language/language.statu...
tests/language/language.status:73: compile_time_constant10_test: Fail # issue
5214
Is that matched? I thought you had to put '/none' to get the whole test.

https://codereview.chromium.org/10949002/diff/1/tests/language/language.statu...
tests/language/language.status:75: compile_time_constant10_test/02: Pass # issue
5214
Maybe also explain why they pass.

https://codereview.chromium.org/10949002/diff/1/tests/language/language.statu...
tests/language/language.status:268: getter_no_setter2_test/01: Fail, Pass # Test
works only for minified output.
Is that related to the 'dynamic' change?

https://codereview.chromium.org/10949002/diff/1/tests/language/language.statu...
tests/language/language.status:390: compile_time_constant10_test: Fail # Triage
this.
Matched?

Expand Messages | Collapse Messages