Issue 10948036: Register iterate-protocol helper if there is for-in.

Issue 10948036: Register iterate-protocol helper if there is for-in. (Closed)

Created:
8 years, 3 months ago by Anton Muhin

Modified:
8 years, 3 months ago

Reviewers:
ahe, karlklose, Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Register iterate-protocol helper if there is for-in. Methods Iterable.iterator, Iterator.next and Iterator.hasNext are invoked implicitly by for-in loops. R=ahe@google.com,karlklose@google.com,smok@google.com Committed: https://code.google.com/p/dart/source/detail?r=12557

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -7 lines)			Patch
	M	lib/compiler/implementation/resolver.dart	View	1	2 chunks	+12 lines, -4 lines	0 comments	Download
	M	tests/co19/co19-dart2js.status	View		2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/10948036/diff/1/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (right): https://codereview.chromium.org/10948036/diff/1/lib/compiler/implementation/resolver.dart#newcode1815 lib/compiler/implementation/resolver.dart:1815: registerHelperMethod(SourceString name, int arity) { How about "registerImplicitInvocation"? ...

8 years, 3 months ago (2012-09-19 12:24:15 UTC) #2

Anton Muhin

Thanks a lot for a quick review. Running through the tests and submitting. https://codereview.chromium.org/10948036/diff/1/lib/compiler/implementation/resolver.dart File ...

8 years, 3 months ago (2012-09-19 12:33:38 UTC) #3

LGTM.

Expand Messages | Collapse Messages