Issue 109473009: Removing media events from Document and Element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109473009: Removing media events from Document and Element. (Closed)

Created:
6 years, 11 months ago by blois

Modified:
6 years, 11 months ago

Reviewers:
vsm, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Removing media events from Document and Element. We were already doing this for Window, but they just got added to Element & Document in Chrome 32. Suppressing them as they aren't needed and can be used from MediaElement already. TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=31562

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -904 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	36 chunks	+0 lines, -450 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	37 chunks	+3 lines, -453 lines	0 comments	Download
M	tools/dom/scripts/htmleventgenerator.py	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

Committed patchset #1 manually as r31562 (presubmit successful).

6 years, 11 months ago (2014-01-07 18:34:43 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages