Issue 1094713003: Fix XMLHTTPRequest JS type in _loadHunk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1094713003: Fix XMLHTTPRequest JS type in _loadHunk (Closed)

Created:
5 years, 8 months ago by sra1

Modified:
5 years, 8 months ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Fix XMLHTTPRequest JS type in _loadHunk Saves ~100K on apps using defered loading TBR=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=45222

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	sdk/lib/_internal/compiler/js_lib/js_helper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

sra1

Sigurd, Which tests use this path? I don't see any test failures if I replace ...

5 years, 8 months ago (2015-04-17 00:20:41 UTC) #1

sra1

On 2015/04/17 00:20:41, sra1 wrote: > Sigurd, > > Which tests use this path? > ...

5 years, 8 months ago (2015-04-17 00:23:52 UTC) #2

sra1

Committed patchset #1 (id:1) manually as 45222 (presubmit successful).

5 years, 8 months ago (2015-04-17 00:30:14 UTC) #3

Message was sent while issue was closed.

LGMT

I think you forgot to put me as reviewer.