Support dependencies in SDK packages.

Support dependencies in SDK packages.

Committed: https://code.google.com/p/dart/source/detail?r=12816

[Bob Nystrom, 2012-09-19 23:30:42]

Fixes: http://code.google.com/p/dart/issues/detail?id=5224

[nweiz, 2012-09-19 23:38:53]

https://codereview.chromium.org/10947050/diff/1/utils/pub/sdk_source.dart
File utils/pub/sdk_source.dart (right):

https://codereview.chromium.org/10947050/diff/1/utils/pub/sdk_source.dart#new...
utils/pub/sdk_source.dart:41: });
This is a lot of unnecessary nesting. Use #chain more :).

https://codereview.chromium.org/10947050/diff/1/utils/tests/pub/pub_install_s...
File utils/tests/pub/pub_install_sdk_test.dart (right):

https://codereview.chromium.org/10947050/diff/1/utils/tests/pub/pub_install_s...
utils/tests/pub/pub_install_sdk_test.dart:44: pubspec({
I think you can use libPubspec here.

https://codereview.chromium.org/10947050/diff/1/utils/tests/pub/pub_install_s...
utils/tests/pub/pub_install_sdk_test.dart:60: pubspec({'name': 'myapp',
'dependencies': {'foo': {'sdk': 'foo'}}})
And appPubspec here.

https://codereview.chromium.org/10947050/diff/1/utils/tests/pub/pub_install_s...
utils/tests/pub/pub_install_sdk_test.dart:64: output: '''
Elsewhere we use `const RegExp(@"Dependencies installed!$")`, which seems a
little more resilient once we start adding more useful output.

[Bob Nystrom, 2012-09-20 01:00:08]

Thanks!

https://codereview.chromium.org/10947050/diff/1/utils/pub/sdk_source.dart
File utils/pub/sdk_source.dart (right):

https://codereview.chromium.org/10947050/diff/1/utils/pub/sdk_source.dart#new...
utils/pub/sdk_source.dart:41: });
On 2012/09/19 23:38:53, nweiz wrote:
> This is a lot of unnecessary nesting. Use #chain more :).

Done.

https://codereview.chromium.org/10947050/diff/1/utils/tests/pub/pub_install_s...
File utils/tests/pub/pub_install_sdk_test.dart (right):

https://codereview.chromium.org/10947050/diff/1/utils/tests/pub/pub_install_s...
utils/tests/pub/pub_install_sdk_test.dart:44: pubspec({
On 2012/09/19 23:38:53, nweiz wrote:
> I think you can use libPubspec here.

Done.

https://codereview.chromium.org/10947050/diff/1/utils/tests/pub/pub_install_s...
utils/tests/pub/pub_install_sdk_test.dart:60: pubspec({'name': 'myapp',
'dependencies': {'foo': {'sdk': 'foo'}}})
On 2012/09/19 23:38:53, nweiz wrote:
> And appPubspec here.

Done.

https://codereview.chromium.org/10947050/diff/1/utils/tests/pub/pub_install_s...
utils/tests/pub/pub_install_sdk_test.dart:64: output: '''
On 2012/09/19 23:38:53, nweiz wrote:
> Elsewhere we use `const RegExp(@"Dependencies installed!$")`, which seems a
> little more resilient once we start adding more useful output.

Done.

[nweiz, 2012-09-24 20:05:52]

lgtm