Issue 10947040: Take three of FooList to List<Foo> again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10947040: Take three of FooList to List<Foo> again. (Closed)

Created:
8 years, 3 months ago by Emily Fortuna

Modified:
8 years, 3 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Take three of FooList to List<Foo> again. Committed: https://code.google.com/p/dart/source/detail?r=12596

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4394 lines, -82 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View	51 chunks	+2184 lines, -52 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	52 chunks	+2160 lines, -28 lines	0 comments	Download
M	lib/html/idl/dart/dart.idl	View	2 chunks	+48 lines, -1 line	1 comment	Download
A +	tests/html/client_rect_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	tests/html/css_rule_list_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tests/html/svg_3_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/html/typing_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Took out HTMLOptionsCollection because it extends from HTMLCollection. https://codereview.chromium.org/10947040/diff/1/lib/html/idl/dart/dart.idl File lib/html/idl/dart/dart.idl (right): https://codereview.chromium.org/10947040/diff/1/lib/html/idl/dart/dart.idl#newcode17 lib/html/idl/dart/dart.idl:17: HTMLAllCollection ...

8 years, 3 months ago (2012-09-19 19:47:38 UTC) #1

lgtm

Expand Messages | Collapse Messages