Issue 10947029: Avoid calling user-defined code when reporting checked mode errors and cast errors.

Issue 10947029: Avoid calling user-defined code when reporting checked mode errors and cast errors. (Closed)

Created:
8 years, 3 months ago by ahe

Modified:
8 years, 3 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Avoid calling user-defined code when reporting checked mode errors and cast errors. Committed: https://code.google.com/p/dart/source/detail?r=12553

Patch Set 2 : Address review comments #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+209 lines, -12 lines)			Patch
M	dart/lib/compiler/implementation/lib/js_helper.dart	View	1	10 chunks	+14 lines, -12 lines	0 comments	Download
M	dart/tests/language/language.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	dart/tests/language/type_error_test.dart	View	1	1 chunk	+194 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/10947029/diff/2001/dart/lib/compiler/implementation/lib/js_helper.dart File dart/lib/compiler/implementation/lib/js_helper.dart (right): https://codereview.chromium.org/10947029/diff/2001/dart/lib/compiler/implementation/lib/js_helper.dart#newcode1273 dart/lib/compiler/implementation/lib/js_helper.dart:1273: final String msg; Change this to message while ...

8 years, 3 months ago (2012-09-19 12:05:01 UTC) #3

ahe

8 years, 3 months ago (2012-09-19 12:11:22 UTC) #4

Thank you for the review!

https://codereview.chromium.org/10947029/diff/2001/dart/lib/compiler/implemen...
File dart/lib/compiler/implementation/lib/js_helper.dart (right):

https://codereview.chromium.org/10947029/diff/2001/dart/lib/compiler/implemen...
dart/lib/compiler/implementation/lib/js_helper.dart:1273: final String msg;
On 2012/09/19 12:05:02, kasperl wrote:
> Change this to message while you're at it?

Done.

https://codereview.chromium.org/10947029/diff/2001/dart/tests/language/type_e...
File dart/tests/language/type_error_test.dart (right):

https://codereview.chromium.org/10947029/diff/2001/dart/tests/language/type_e...
dart/tests/language/type_error_test.dart:122: wrap(e) {
On 2012/09/19 12:05:02, kasperl wrote:
> Add a comment that explains why you're doing this.

Done. Also used wrap in all the FooTypeError classes.

Expand Messages | Collapse Messages