Issue 10947006: element.isMember does not imply element.enclosingElement.isClass? can we fix that?

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10947006: element.isMember does not imply element.enclosingElement.isClass? can we fix that? (Closed)

Created:
8 years, 3 months ago by ngeoffray

Modified:
8 years, 3 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

element.isMember does not imply element.enclosingElement.isClass? can we fix that? Committed: https://code.google.com/p/dart/source/detail?r=12478

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	lib/compiler/implementation/closure.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

8 years, 3 months ago (2012-09-18 20:02:24 UTC) #2

LGTM

The problem is VariableElement which is always a child of VariableListElement.
This is need to handle multiple variable declarations like

  int a, b, c;

Here VariableListElement holds the common type and there is a VariableElement
for each of a, b, and c. 

I think we should rewrite most of are predicates in Element so that this anomaly
is handle by VariableElement itself.

Expand Messages | Collapse Messages