Issue 10946007: Never send reserved status codes in a close frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10946007: Never send reserved status codes in a close frame (Closed)

Created:
8 years, 3 months ago by Søren Gjesse

Modified:
8 years, 3 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Never send reserved status codes in a close frame When receiving a close frame with no status code the reported status code is 1005. If the close is echoed as part of the close handshake the echoed close frame must also have no status code and NOT status code 1005. The description of status code 1005 from the spec: 1005 is a reserved value and MUST NOT be set as a status code in a Close control frame by an endpoint. It is designated for use in applications expecting a status code to indicate that no status code was actually present. R=ajohnsen@google.com BUG=dart:5209 Committed: https://code.google.com/p/dart/source/detail?r=12482

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -6 lines)			Patch
M	runtime/bin/websocket.dart	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/bin/websocket_impl.dart	View	3 chunks	+14 lines, -1 line	0 comments	Download
M	tests/standalone/io/web_socket_test.dart	View	4 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages