Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1094533005: When testing, make sure we run Dart from an absolute path. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

When testing, make sure we run Dart from an absolute path. The bots pass in relative paths, which breaks when we run processes with new working directories. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/46e0cc1797e9fef78a4fe7de9c6c39864462a9de

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M test/io.dart View 1 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 8 months ago (2015-04-21 22:42:03 UTC) #1
kevmoo
lgtm https://codereview.chromium.org/1094533005/diff/1/test/io.dart File test/io.dart (right): https://codereview.chromium.org/1094533005/diff/1/test/io.dart#newcode41 test/io.dart:41: // The bots use a relative package root, ...
5 years, 8 months ago (2015-04-21 22:53:10 UTC) #2
nweiz
Code review changes
5 years, 8 months ago (2015-04-21 22:57:28 UTC) #3
nweiz
https://codereview.chromium.org/1094533005/diff/1/test/io.dart File test/io.dart (right): https://codereview.chromium.org/1094533005/diff/1/test/io.dart#newcode41 test/io.dart:41: // The bots use a relative package root, which ...
5 years, 8 months ago (2015-04-21 22:57:33 UTC) #4
nweiz
5 years, 8 months ago (2015-04-21 22:57:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
46e0cc1797e9fef78a4fe7de9c6c39864462a9de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698