Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 10945027: Remove >>> and >>>= from scanner. (Closed)

Created:
8 years, 3 months ago by ahe
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove >>> and >>>= from scanner. Committed: https://code.google.com/p/dart/source/detail?r=12713

Patch Set 1 #

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M dart/lib/compiler/implementation/scanner/scanner.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M dart/lib/compiler/implementation/scanner/token.dart View 1 5 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ahe
8 years, 3 months ago (2012-09-19 15:42:48 UTC) #1
Anton Muhin
what about isUserDefinableOperator from token.dart?
8 years, 3 months ago (2012-09-19 15:43:52 UTC) #2
Lasse Reichstein Nielsen
What Anton said. Otherwise LGTM.
8 years, 3 months ago (2012-09-19 15:58:32 UTC) #3
ahe
PTAL
8 years, 3 months ago (2012-09-19 15:59:13 UTC) #4
Anton Muhin
lgtm
8 years, 3 months ago (2012-09-19 16:14:54 UTC) #5
Lasse Reichstein Nielsen
lgtm
8 years, 3 months ago (2012-09-19 16:19:09 UTC) #6
Anton Muhin
8 years, 3 months ago (2012-09-21 09:48:53 UTC) #7
Any chance for this to get landed today?

Powered by Google App Engine
This is Rietveld 408576698