Issue 10945025: Remove check for stack overflow on entry to an inlined function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10945025: Remove check for stack overflow on entry to an inlined function. (Closed)

Created:
8 years, 3 months ago by zerny-google

Modified:
8 years, 3 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove check for stack overflow on entry to an inlined function. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=12556

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	runtime/vm/flow_graph_builder.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

8 years, 3 months ago (2012-09-19 12:01:17 UTC) #2

LGTM but it needs a comment to prevent someone (me?) from forgetting about the
side effect and deleting the "dead" definition.

https://codereview.chromium.org/10945025/diff/1/runtime/vm/flow_graph_builder.cc
File runtime/vm/flow_graph_builder.cc (right):

https://codereview.chromium.org/10945025/diff/1/runtime/vm/flow_graph_builder...
runtime/vm/flow_graph_builder.cc:2608: Definition* check = new
CheckStackOverflowInstr(function.token_pos());
Please add a comment that we allocate the instruction in all cases to assign a
deopt id to it, but discard the instruction if inlining.

Expand Messages | Collapse Messages