Issue 10945007: Bug cleanup: add comment about unspecified behavior if the object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10945007: Bug cleanup: add comment about unspecified behavior if the object (Closed)

Created:
8 years, 3 months ago by Mads Ager (google)

Modified:
8 years, 3 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Bug cleanup: add comment about unspecified behavior if the object iterated over with an iterator is changed during the iteration. R=ngeoffray@google.com BUG=dartbug.com/442 Committed: https://code.google.com/p/dart/source/detail?r=12493

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	lib/core/iterator.dart	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/10945007/diff/1/lib/core/iterator.dart File lib/core/iterator.dart (right): https://codereview.chromium.org/10945007/diff/1/lib/core/iterator.dart#newcode11 lib/core/iterator.dart:11: * behavior is unspecified. iteration, the behavior...

8 years, 3 months ago (2012-09-18 12:18:13 UTC) #2

Mads Ager (google)

8 years, 3 months ago (2012-09-18 12:39:01 UTC) #3

https://codereview.chromium.org/10945007/diff/1/lib/core/iterator.dart
File lib/core/iterator.dart (right):

https://codereview.chromium.org/10945007/diff/1/lib/core/iterator.dart#newcode11
lib/core/iterator.dart:11: * behavior is unspecified.
On 2012/09/18 12:18:18, ngeoffray wrote:
> iteration, the behavior...

Done.

Expand Messages | Collapse Messages