Issue 10945005: Fix expectations after introducing "identical". Again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10945005: Fix expectations after introducing "identical". Again. (Closed)

Created:
8 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 3 months ago

Reviewers:
ricow1, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix expectations after introducing "identical". Again. TBR=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=12468

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -12 lines)			Patch
	M	tests/language/language.status	View		4 chunks	+3 lines, -12 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/10945005/diff/1/tests/language/language.status File tests/language/language.status (left): https://codereview.chromium.org/10945005/diff/1/tests/language/language.status#oldcode118 tests/language/language.status:118: argument_definition_test/05: Fail # Issue 5082 How did you ...

8 years, 3 months ago (2012-09-18 07:14:35 UTC) #1

Lasse Reichstein Nielsen

8 years, 3 months ago (2012-09-18 08:22:36 UTC) #2

https://codereview.chromium.org/10945005/diff/1/tests/language/language.status
File tests/language/language.status (left):

https://codereview.chromium.org/10945005/diff/1/tests/language/language.statu...
tests/language/language.status:118: argument_definition_test/05: Fail # Issue
5082
Yes, a bad merge reintroduced them.
Morale: Reload your buffers before continuing to work on the same files as
yesterday.

Expand Messages | Collapse Messages