Issue 1094453006: Support rethrow in the dart2js JS backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1094453006: Support rethrow in the dart2js JS backend. (Closed)

Created:
5 years, 8 months ago by Kevin Millikin (Google)

Modified:
5 years, 8 months ago

Reviewers:
karlklose, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Support rethrow in the dart2js JS backend. The approach is simple: translate rethrow to a throw of the enclosing catch block's JS exception. There is already an assert that the JS backend does not see rethrow at code generation time. R=karlklose@google.com, floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45397

Patch Set 1 #

Total comments: 1

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -6 lines)			Patch
	M	pkg/compiler/lib/src/js_backend/codegen/unsugar.dart	View		4 chunks	+32 lines, -5 lines	0 comments	Download
	M	tests/language/language_dart2js.status	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

karlklose

LGTM. https://codereview.chromium.org/1094453006/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (left): https://codereview.chromium.org/1094453006/diff/1/tests/language/language_dart2js.status#oldcode822 tests/language/language_dart2js.status:822: deferred_in_isolate_test: Crash # (rethrow;): Unhandled node Are there ...

5 years, 8 months ago (2015-04-23 12:43:22 UTC) #3

Kevin Millikin (Google)

5 years, 8 months ago (2015-04-24 11:23:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45397 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages