Issue 1094433003: tree-ir: Move labeled statements outside loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1094433003: tree-ir: Move labeled statements outside loops. (Closed)

Created:
5 years, 8 months ago by asgerf

Modified:
5 years, 7 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -17 lines)			Patch
	M	pkg/compiler/lib/src/tree_ir/optimization/loop_rewriter.dart	View		4 chunks	+61 lines, -7 lines	0 comments	Download
	M	tests/compiler/dart2js/js_backend_cps_ir_control_flow_test.dart	View	1 2	1 chunk	+8 lines, -10 lines	0 comments	Download

Total messages: 5 (1 generated)

Kevin Millikin (Google)

Nice, LGTM. I do wonder if this is better to do here or as a ...

5 years, 8 months ago (2015-04-17 08:46:38 UTC) #3

asgerf

Yes, lifting LetConts should have the same effect. But if it works here, then I ...

5 years, 8 months ago (2015-04-17 08:49:39 UTC) #4

asgerf

5 years, 7 months ago (2015-05-04 11:26:30 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 45486 (presubmit successful).