Issue 10944041: Ensure that parser throws an error when parsing x is! T with malformed type T.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10944041: Ensure that parser throws an error when parsing x is! T with malformed type T. (Closed)

Created:
8 years, 3 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 3 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ensure that parser throws an error when parsing x is! T with malformed type T. Otherwise VM crashes in the flow graph builder R=regis@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12608

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix comment in the test. #

Patch Set 3 : make test positive #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -13 lines)			Patch
	M	runtime/vm/parser.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	A +	tests/language/isnot_malformed_type_test.dart	View	1 2	1 chunk	+7 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with one comment about the test. Thanks for the fix. -- Regis https://codereview.chromium.org/10944041/diff/1/tests/language/isnot_malformed_type_negative_test.dart File ...

8 years, 3 months ago (2012-09-19 21:35:01 UTC) #2

Vyacheslav Egorov (Google)

8 years, 3 months ago (2012-09-19 21:47:35 UTC) #3

Did not know about test annotations in comments... Thanks for the tip!

Made test positive. 

Landing.

Expand Messages | Collapse Messages