Issue 10944035: Use more semantic exit codes so we can detect HTTP errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10944035: Use more semantic exit codes so we can detect HTTP errors. (Closed)

Created:
8 years, 3 months ago by nweiz

Modified:
8 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use more semantic exit codes so we can detect HTTP errors. Committed: https://code.google.com/p/dart/source/detail?r=12586

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -9 lines)			Patch
A	utils/pub/exit_codes.dart	View	1 chunk	+55 lines, -0 lines	0 comments	Download
M	utils/pub/hosted_source.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/io.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	utils/pub/pub.dart	View	5 chunks	+17 lines, -5 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One suggestion, but LGTM. https://codereview.chromium.org/10944035/diff/1/utils/pub/pub.dart File utils/pub/pub.dart (right): https://codereview.chromium.org/10944035/diff/1/utils/pub/pub.dart#newcode263 utils/pub/pub.dart:263: int _exitCode(exception) { How about ...

8 years, 3 months ago (2012-09-19 18:27:42 UTC) #2

nweiz

8 years, 3 months ago (2012-09-19 18:33:56 UTC) #3

https://codereview.chromium.org/10944035/diff/1/utils/pub/pub.dart
File utils/pub/pub.dart (right):

https://codereview.chromium.org/10944035/diff/1/utils/pub/pub.dart#newcode263
utils/pub/pub.dart:263: int _exitCode(exception) {
On 2012/09/19 18:27:42, Bob Nystrom wrote:
> How about a nice verby name like _chooseExitCode?

Done.

Expand Messages | Collapse Messages