- Removed comment to Frog and eliminated usage of sentinel.

- Removed comment to Frog and eliminated usage of sentinel.
  It is not pretty BUT short of having a working reflective interface this change is an improvment.
Committed: https://code.google.com/p/dart/source/detail?r=12480

[ahe, 2012-09-18 09:55:18]

+gram

[kasperl, 2012-09-18 10:07:56]

LGTM. The change looks fine but having to go through all this pain makes me
wonder if the interface for this is optimal. There's a bad smell associated with
all these ifs.

https://codereview.chromium.org/10944006/diff/1/pkg/unittest/mock.dart
File pkg/unittest/mock.dart (left):

https://codereview.chromium.org/10944006/diff/1/pkg/unittest/mock.dart#oldcode44
pkg/unittest/mock.dart:44: const _noArg = const _Sentinel();
Can you also get rid of the _Sentinel class?

[bakster, 2012-09-18 10:23:54]

//Lars

https://codereview.chromium.org/10944006/diff/1/pkg/unittest/mock.dart
File pkg/unittest/mock.dart (left):

https://codereview.chromium.org/10944006/diff/1/pkg/unittest/mock.dart#oldcode44
pkg/unittest/mock.dart:44: const _noArg = const _Sentinel();
On 2012/09/18 10:07:56, kasperl wrote:
> Can you also get rid of the _Sentinel class?
Look inside unittest.dart. It was eliminated.

[kasperl, 2012-09-18 10:52:25]

https://codereview.chromium.org/10944006/diff/1/pkg/unittest/unittest.dart
File pkg/unittest/unittest.dart (right):

https://codereview.chromium.org/10944006/diff/1/pkg/unittest/unittest.dart#ne...
pkg/unittest/unittest.dart:363: if (?arg0) return _callback();
!?arg0