Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 10943002: Improve dlsym() error-detection. (Closed)

Created:
8 years, 3 months ago by jackpal
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Improve dlsym() error-detection. Avoid false-positive error detection by calling dlerror() once (and ignoring the result) before calling dlsym(). See "man dlsym" on a Linux machine for more discussion of how to detect errors when calling dlsym(). Committed: https://code.google.com/p/dart/source/detail?r=12504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M runtime/bin/extensions_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/extensions_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/extensions_macos.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jackpal
Assuming Bill Hesse would be a good reviewer for this as he wrote the documentation ...
8 years, 3 months ago (2012-09-17 23:52:17 UTC) #1
William Hesse
8 years, 3 months ago (2012-09-18 08:32:49 UTC) #2
LGTM.  Thanks.

Powered by Google App Engine
This is Rietveld 408576698