Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 109423004: Formatter line continuation awareness hooks. (Closed)

Created:
7 years ago by pquitslund
Modified:
7 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Formatter line continuation awareness hooks. DO indent continued lines with at least four spaces. https://www.dartlang.org/articles/style-guide/#do-indent-continued-lines-with-at-least-four-spaces NOTE: these are just the hooks. As per our conversations, we need to encode opinions about what continuations should be allowed before we support them. The tests are left, commented out, to serve as tracer bullets when we get there. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=31210

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -31 lines) Patch
M pkg/analyzer/lib/src/services/formatter_impl.dart View 1 2 14 chunks +67 lines, -31 lines 0 comments Download
M pkg/analyzer/test/services/formatter_test.dart View 1 1 chunk +117 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pquitslund
7 years ago (2013-12-13 22:30:32 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/109423004/diff/1/pkg/analyzer/lib/src/services/formatter_impl.dart File pkg/analyzer/lib/src/services/formatter_impl.dart (right): https://codereview.chromium.org/109423004/diff/1/pkg/analyzer/lib/src/services/formatter_impl.dart#newcode1349 pkg/analyzer/lib/src/services/formatter_impl.dart:1349: indent(2); Do we want to increase the indentation ...
7 years ago (2013-12-13 22:38:03 UTC) #2
pquitslund
Updated to remove actual handling, leaving only the hooks for future filling in.
7 years ago (2013-12-17 22:17:51 UTC) #3
Brian Wilkerson
LGTM
7 years ago (2013-12-17 22:20:29 UTC) #4
pquitslund
7 years ago (2013-12-17 22:38:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r31210 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698