Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10942017: Fixing up Table.createTBody et al. (Closed)

Created:
8 years, 3 months ago by blois
Modified:
8 years, 3 months ago
Reviewers:
vsm, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing up Table.createTBody et al. BUG=4342 Committed: https://code.google.com/p/dart/source/detail?r=12662

Patch Set 1 #

Patch Set 2 : Splitting out changing return type of create* methods. #

Patch Set 3 : Removing errant line from TableElement.darttemplate. #

Total comments: 2

Patch Set 4 : Switched to using JS-forms. #

Total comments: 1

Patch Set 5 : Incorporating review feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -7 lines) Patch
M lib/html/dart2js/html_dart2js.dart View 3 chunks +15 lines, -2 lines 0 comments Download
M lib/html/scripts/systemhtml.py View 1 1 chunk +1 line, -0 lines 0 comments Download
A + lib/html/templates/html/dart2js/impl_TableElement.darttemplate View 1 2 3 4 1 chunk +9 lines, -5 lines 0 comments Download
A tests/html/table_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
8 years, 3 months ago (2012-09-20 20:13:51 UTC) #1
sra1
https://codereview.chromium.org/10942017/diff/5001/lib/html/templates/html/dart2js/impl_TableElement.darttemplate File lib/html/templates/html/dart2js/impl_TableElement.darttemplate (right): https://codereview.chromium.org/10942017/diff/5001/lib/html/templates/html/dart2js/impl_TableElement.darttemplate#newcode8 lib/html/templates/html/dart2js/impl_TableElement.darttemplate:8: _ElementImpl createTBody() native ''' Please avoid this form of ...
8 years, 3 months ago (2012-09-20 20:40:49 UTC) #2
blois
https://codereview.chromium.org/10942017/diff/5001/lib/html/templates/html/dart2js/impl_TableElement.darttemplate File lib/html/templates/html/dart2js/impl_TableElement.darttemplate (right): https://codereview.chromium.org/10942017/diff/5001/lib/html/templates/html/dart2js/impl_TableElement.darttemplate#newcode8 lib/html/templates/html/dart2js/impl_TableElement.darttemplate:8: _ElementImpl createTBody() native ''' On 2012/09/20 20:40:49, sra1 wrote: ...
8 years, 3 months ago (2012-09-20 21:06:41 UTC) #3
sra1
8 years, 3 months ago (2012-09-20 22:39:12 UTC) #4 
LGTM with # fix

https://codereview.chromium.org/10942017/diff/10001/lib/html/templates/html/d...
File lib/html/templates/html/dart2js/impl_TableElement.darttemplate (right):

https://codereview.chromium.org/10942017/diff/10001/lib/html/templates/html/d...
lib/html/templates/html/dart2js/impl_TableElement.darttemplate:9: if (JS('bool',
'!!this.createTBody')) {
Don't use 'this' in the JS-code. Always pass it in:

  JS('bool', '!!#.createTBody', this)

The compiler is free to compile the body any way it pleases.  E.g. it could
abstract out parts of the body into a top-level function to save space, where
'this' is passed to a parameter called 'X'. 
Then the correct JS code would be  !!X.createTBody

Powered by Google App Engine
This is Rietveld 408576698