Issue 10941018: Constraint List length values to the Smi type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10941018: Constraint List length values to the Smi type. (Closed)

Created:
8 years, 3 months ago by cshapiro

Modified:
8 years, 3 months ago

Reviewers:
siva, hausner

CC:
turnidge, reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Constraint List length values to the Smi type. This change also makes the fast path and slow path cases in some integer handling functions explicit. Values are asserted not to be a Smi in the slow path as they should have been picked off in the fast path. BUG=https://code.google.com/p/dart/issues/detail?id=1750 Committed: https://code.google.com/p/dart/source/detail?r=12527

Patch Set 1 #

Total comments: 1

Patch Set 2 : address review comments #

Patch Set 3 : address review comments, take 2 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -22 lines)			Patch
	M	runtime/vm/dart_api_impl.cc	View	1 2	6 chunks	+33 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

8 years, 3 months ago (2012-09-19 00:57:34 UTC) #3

LGTM with one comment regarding kIntptrMax instead of kSmiMax

http://codereview.chromium.org/10941018/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/10941018/diff/1/runtime/vm/dart_api_impl.cc#ne...
runtime/vm/dart_api_impl.cc:1845: return Api::Success(isolate);
As discussed offline we should probably allow for values upto kIntptrMax instead
of restricting it to kSmiMax.

Expand Messages | Collapse Messages