Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1094083003: Re-apply change to move to plugin package (Closed)

Created:
5 years, 8 months ago by Brian Wilkerson
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-apply change to move to plugin package R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -600 lines) Patch
M pkg/analysis_server/lib/plugin/assist.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/plugin/completion.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/plugin/fix.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/plugin/index.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/get_handler.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 3 chunks +126 lines, -126 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/starter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/format_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/sort_members_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/analyzer/lib/plugin/plugin.dart View 1 chunk +0 lines, -130 lines 0 comments Download
M pkg/analyzer/lib/plugin/task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/analyzer/lib/src/plugin/plugin_impl.dart View 1 chunk +0 lines, -125 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
D pkg/analyzer/test/plugin/plugin_impl_test.dart View 1 chunk +0 lines, -174 lines 0 comments Download
D pkg/analyzer/test/plugin/test_all.dart View 1 chunk +0 lines, -19 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 8 months ago (2015-04-24 16:48:20 UTC) #2
scheglov
LGTM
5 years, 8 months ago (2015-04-24 17:06:08 UTC) #3
Brian Wilkerson
5 years, 8 months ago (2015-04-24 18:54:51 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 45408 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698