Issue 10939027: Issue 5116. Support both 'dynamic' and 'Dynamic'

Issue 10939027: Issue 5116. Support both 'dynamic' and 'Dynamic' (Closed)

Created:
8 years, 3 months ago by scheglov

Modified:
8 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 5116. Support both 'dynamic' and 'Dynamic' http://code.google.com/p/dart/issues/detail?id=5116 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12567

Patch Set 2 : Use DartParser.DYNAMIC_KEYWORD #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -40 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/DynamicTypeImplementation.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	1	23 chunks	+45 lines, -31 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractUtils.java	View	1	3 chunks	+13 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/ExtractUtilsTest.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/10939027/diff/1/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java File compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java (right): https://codereview.chromium.org/10939027/diff/1/compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java#newcode217 compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java:217: if (DartParser.PSEUDO_KEYWORDS_SET.contains(name) && !"dynamic".equals(name) && !"Dynamic".equals(name)) { It ...

8 years, 3 months ago (2012-09-19 13:17:49 UTC) #2

scheglov

8 years, 3 months ago (2012-09-19 15:39:57 UTC) #3

https://codereview.chromium.org/10939027/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java
(right):

https://codereview.chromium.org/10939027/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java:217: if
(DartParser.PSEUDO_KEYWORDS_SET.contains(name) && !"dynamic".equals(name) &&
!"Dynamic".equals(name)) {
On 2012/09/19 13:17:49, Brian Wilkerson wrote:
> It would be better to use the constants defined in DartParser than literal
> strings.

Done.

https://codereview.chromium.org/10939027/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java:274: if
(Elements.isIdentifierName(identifier, "dynamic")) {
On 2012/09/19 13:17:49, Brian Wilkerson wrote:
> It would be better to use the constants defined in DartParser.

Done.

https://codereview.chromium.org/10939027/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractUtils.java
(right):

https://codereview.chromium.org/10939027/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractUtils.java:111:
if ("dynamic".equals(typeSource)) {
On 2012/09/19 13:17:49, Brian Wilkerson wrote:
> It would be better to use the constants defined in DartParser.

Done.

Expand Messages | Collapse Messages