Issue 10939020: Don't invoke user-defined code in NoSuchMethodError.toString.

Issue 10939020: Don't invoke user-defined code in NoSuchMethodError.toString. (Closed)

Created:
8 years, 3 months ago by ahe

Modified:
8 years, 3 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, bakster, Lasse Reichstein Nielsen, srdjan

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't invoke user-defined code in NoSuchMethodError.toString. Committed: https://code.google.com/p/dart/source/detail?r=12533

Patch Set 2 : Address review comments. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -3 lines)			Patch
M	dart/lib/compiler/implementation/lib/core_patch.dart	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	dart/lib/core/errors.dart	View		2 chunks	+6 lines, -3 lines	0 comments	Download
A	dart/runtime/lib/errors_patch.dart	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	dart/runtime/lib/lib_sources.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	dart/tests/corelib/safe_to_string_test.dart	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

Before: Unhandled exception: <Received error while converting exception to string> #0 Object._noSuchMethod (dart:core-patch:2496:3) #1 Object.noSuchMethod ...

8 years, 3 months ago (2012-09-18 15:51:30 UTC) #1

kasperl

LGTM! https://codereview.chromium.org/10939020/diff/4001/dart/tests/corelib/safe_to_string_test.dart File dart/tests/corelib/safe_to_string_test.dart (right): https://codereview.chromium.org/10939020/diff/4001/dart/tests/corelib/safe_to_string_test.dart#newcode8 dart/tests/corelib/safe_to_string_test.dart:8: Expect.stringEquals('"1"', NoSuchMethodError.safeToString("1")); Add test for the escaping of ...

8 years, 3 months ago (2012-09-19 06:26:36 UTC) #2

ahe

8 years, 3 months ago (2012-09-19 07:47:52 UTC) #3

ahe

8 years, 3 months ago (2012-09-19 07:48:08 UTC) #4

On 2012/09/19 07:47:52, ahe wrote:
> LGTM!

I mean, thank you!

Expand Messages | Collapse Messages