Fix finding locale from OS on Windows

Fix finding locale from OS on Windows
Committed: https://code.google.com/p/dart/source/detail?r=12505

[Alan Knight, 2012-09-17 23:58:06]

Added the change to the status file to run those tests on Windows again.

[Emily Fortuna, 2012-09-18 00:46:33]

lgtm

https://codereview.chromium.org/10939002/diff/3001/pkg/intl/intl.dart
File pkg/intl/intl.dart (right):

https://codereview.chromium.org/10939002/diff/3001/pkg/intl/intl.dart#newcode145
pkg/intl/intl.dart:145: if (aLocale == "C") return "en_ISO";
what does "C" mean?

[Alan Knight, 2012-09-18 17:08:36]

https://codereview.chromium.org/10939002/diff/3001/pkg/intl/intl.dart
File pkg/intl/intl.dart (right):

https://codereview.chromium.org/10939002/diff/3001/pkg/intl/intl.dart#newcode145
pkg/intl/intl.dart:145: if (aLocale == "C") return "en_ISO";
On 2012/09/18 00:46:33, Emily Fortuna wrote:
> what does "C" mean?

It's an old Unix locale, also referred to as the Posix locale. It uses 7-bit
ascii, and some basic date formatting conventions. You don't see it a whole lot
on a real system nowadays, but you do get it as the locale on Cygwin, so I
thought it was worth compensating for it, and at least making sure it got
English conventions. The en_ISO is probably not quite right for date and number
formats, but I don't think we're likely to see it for end users, so it's
probably ok if we're close enough. But I put in a TODO to validate it and
consider including real data for it.

[Emily Fortuna, 2012-09-18 17:38:09]

https://codereview.chromium.org/10939002/diff/3001/pkg/intl/intl.dart
File pkg/intl/intl.dart (right):

https://codereview.chromium.org/10939002/diff/3001/pkg/intl/intl.dart#newcode145
pkg/intl/intl.dart:145: if (aLocale == "C") return "en_ISO";
On 2012/09/18 17:08:36, Alan Knight wrote:
> On 2012/09/18 00:46:33, Emily Fortuna wrote:
> > what does "C" mean?
> 
> It's an old Unix locale, also referred to as the Posix locale. It uses 7-bit
> ascii, and some basic date formatting conventions. You don't see it a whole
lot
> on a real system nowadays, but you do get it as the locale on Cygwin, so I
> thought it was worth compensating for it, and at least making sure it got
> English conventions. The en_ISO is probably not quite right for date and
number
> formats, but I don't think we're likely to see it for end users, so it's
> probably ok if we're close enough. But I put in a TODO to validate it and
> consider including real data for it.

Can you maybe mention a little bit of that in your comment above? (ignore if
this is common knowledge)