Issue 1093873002: Revert "Type and constant propagator should guard against mutable class ids."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1093873002: Revert "Type and constant propagator should guard against mutable class ids." (Closed)

Created:
5 years, 8 months ago by Vyacheslav Egorov (Google)

Modified:
5 years, 8 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Revert "Type and constant propagator should guard against mutable class ids." This reverts commit r45243. Reason: VM segfauls when running dart2js in Release mode. TBR=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=45245

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -136 lines)			Patch
M	runtime/vm/constant_propagator.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 chunk	+0 lines, -113 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	5 chunks	+6 lines, -16 lines	0 comments	Download

Total messages: 3 (0 generated)

Vyacheslav Egorov (Google)

Committed patchset #1 (id:1) manually as 45245 (presubmit successful).

5 years, 8 months ago (2015-04-17 17:40:03 UTC) #2

Message was sent while issue was closed.

lgtm