Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10938011: Delete code for the now unused IL instruction NumberNegate. (Closed)

Created:
8 years, 3 months ago by Florian Schneider
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Delete code for the now unused IL instruction NumberNegate. It was replaced by an unboxed double operation in a previous change. Committed: https://code.google.com/p/dart/source/detail?r=12539

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -210 lines) Patch
M runtime/vm/flow_graph_compiler_ia32.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 1 chunk +0 lines, -26 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 1 chunk +0 lines, -26 lines 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +0 lines, -32 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Schneider
8 years, 3 months ago (2012-09-19 07:33:48 UTC) #1
Kevin Millikin (Google)
8 years, 3 months ago (2012-09-19 07:42:38 UTC) #2
LGTM and thanks for catching this.

Powered by Google App Engine
This is Rietveld 408576698