Issue 10937030: Make some static helpers into member functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10937030: Make some static helpers into member functions. (Closed)

Created:
8 years, 3 months ago by Kevin Millikin (Google)

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make some static helpers into member functions. Four helper functions that moved from lib/integers.cc to vm/object.cc so they could be used during constant folding are more properly member functions than static functions. R=srdjan@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12620

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -62 lines)			Patch
M	runtime/lib/integers.cc	View	13 chunks	+14 lines, -14 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/object.h	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	runtime/vm/object.cc	View	5 chunks	+32 lines, -37 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

Florian, can you take a quick look at this?

8 years, 3 months ago (2012-09-20 08:21:38 UTC) #2

lgtm

Expand Messages | Collapse Messages