Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 10937024: Refactor utils/compiler/buildbot.py (partly to fix IE bots, partly because it needs it) (Closed)

Created:
8 years, 3 months ago by ricow1
Modified:
8 years, 3 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Refactor utils/compiler/buildbot.py (partly to fix IE bots, partly because it needs it) This change will: Disallow bots starting with web- Support the new naming schema for the ie bots (I explicitly set this to html|all, but we can change it to a generic identifier if you like) Introduces a new BuildInfo class that we return from GetBuildInfo instead of a huge tupple; I want to start passing this around instead of explicitly giving all the arguments to e.g., TestCompiler, but currently I don't do it due to our special cases. Removes the ie sharding todos since we now have an explicit way of passing allong which tests we want based on the name (I am not stating that this is a good solution, but until we have more bots to shard across I think this is better than what we had) Committed: https://code.google.com/p/dart/source/detail?r=12535

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -55 lines) Patch
M utils/compiler/buildbot.py View 9 chunks +72 lines, -55 lines 2 comments Download

Messages

Total messages: 2 (0 generated)
ricow1
8 years, 3 months ago (2012-09-19 07:06:35 UTC) #1
ahe
8 years, 3 months ago (2012-09-19 07:42:15 UTC) #2
LGTM!

Really nice.

https://codereview.chromium.org/10937024/diff/1/utils/compiler/buildbot.py
File utils/compiler/buildbot.py (right):

https://codereview.chromium.org/10937024/diff/1/utils/compiler/buildbot.py#ne...
utils/compiler/buildbot.py:222: flags += ['-j1']
We should have a TODO and bug for removing -j1.

https://codereview.chromium.org/10937024/diff/1/utils/compiler/buildbot.py#ne...
utils/compiler/buildbot.py:282: TestStep("dart2js", mode, system, 'dart2js',
runtime, ['dartc',
It is still a problem to use an explicit list of tests. So there should be a
TODO.

Powered by Google App Engine
This is Rietveld 408576698