Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10937019: First pass at getting git and tar.gz working on Windows. (Closed)

Created:
8 years, 3 months ago by Bob Nystrom
Modified:
8 years, 3 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

First pass at getting git and tar.gz working on Windows. Committed: https://code.google.com/p/dart/source/detail?r=12573

Patch Set 1 #

Patch Set 2 : Don't enable all of the Windows tests yet. #

Total comments: 4

Patch Set 3 : Respond to review, rebase against latest. #

Patch Set 4 : Remove merge bug and fix long line. #

Patch Set 5 : Fix merge bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -20 lines) Patch
M tools/create_sdk.py View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
M utils/pub/io.dart View 1 2 3 4 7 chunks +64 lines, -9 lines 0 comments Download
M utils/tests/pub/pub.status View 1 2 3 4 1 chunk +5 lines, -7 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 1 2 3 1 chunk +24 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
This gets us farther along with Windows support. Git and tar.gz work. Unfortunately, the hosted ...
8 years, 3 months ago (2012-09-18 22:46:25 UTC) #1
nweiz
lgtm https://chromiumcodereview.appspot.com/10937019/diff/1005/utils/pub/io.dart File utils/pub/io.dart (right): https://chromiumcodereview.appspot.com/10937019/diff/1005/utils/pub/io.dart#newcode458 utils/pub/io.dart:458: destination = _getPath(destination); Why not do this before ...
8 years, 3 months ago (2012-09-18 23:07:12 UTC) #2
Bob Nystrom
8 years, 3 months ago (2012-09-19 15:57:54 UTC) #3 
Thanks!

https://chromiumcodereview.appspot.com/10937019/diff/1005/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/10937019/diff/1005/utils/pub/io.dart#n...
utils/pub/io.dart:458: destination = _getPath(destination);
On 2012/09/18 23:07:12, nweiz wrote:
> Why not do this before passing it in to _extractTarGzWindows?

Done.

https://chromiumcodereview.appspot.com/10937019/diff/1005/utils/tests/pub/tes...
File utils/tests/pub/test_pub.dart (right):

https://chromiumcodereview.appspot.com/10937019/diff/1005/utils/tests/pub/tes...
utils/tests/pub/test_pub.dart:985: var command = "C:\\Program Files
(x86)\\7-Zip\\7z.exe";
On 2012/09/18 23:07:12, nweiz wrote:
> Make this a real path

Oopsie! Done.

Powered by Google App Engine
This is Rietveld 408576698