Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1093363002: Refactor DartTypeVisitor and ElementVisitor. (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Refactor DartTypeVisitor and ElementVisitor. This enables more patterns of use. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=45314

Patch Set 1 #

Total comments: 6

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -142 lines) Patch
M pkg/compiler/lib/src/closure.dart View 3 chunks +9 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/dart_types.dart View 1 5 chunks +35 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 8 chunks +15 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 20 chunks +59 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/elements/visitor.dart View 1 1 chunk +152 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 1 2 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 5 chunks +9 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/class_element_parser.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 chunks +1 line, -7 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 2 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 8 months ago (2015-04-21 12:06:42 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1093363002/diff/1/pkg/compiler/lib/src/dump_info.dart File pkg/compiler/lib/src/dump_info.dart (right): https://codereview.chromium.org/1093363002/diff/1/pkg/compiler/lib/src/dump_info.dart#newcode104 pkg/compiler/lib/src/dump_info.dart:104: Map<String, dynamic> apply(Element e, [_]) => e.accept(this, null); ...
5 years, 8 months ago (2015-04-21 13:10:34 UTC) #3
Johnni Winther
https://codereview.chromium.org/1093363002/diff/1/pkg/compiler/lib/src/dump_info.dart File pkg/compiler/lib/src/dump_info.dart (right): https://codereview.chromium.org/1093363002/diff/1/pkg/compiler/lib/src/dump_info.dart#newcode104 pkg/compiler/lib/src/dump_info.dart:104: Map<String, dynamic> apply(Element e, [_]) => e.accept(this, null); On ...
5 years, 8 months ago (2015-04-21 13:37:05 UTC) #4
Johnni Winther
5 years, 8 months ago (2015-04-21 13:47:53 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:2) manually as 45314 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698