Issue 10933125: MSVS output to /build/ dir.

Issue 10933125: MSVS output to /build/ dir. (Closed)

Created:
8 years, 3 months ago by Johnni Winther

Modified:
8 years, 3 months ago

Reviewers:
ricow1, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

MSVS output to /build/ dir. Committed: https://code.google.com/p/dart/source/detail?r=12471

Patch Set 2 : bat files updated #

Total comments: 6

Patch Set 3 : Comment updated #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -8 lines)			Patch
M	tools/clean_output_directory.py	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	tools/create_sdk.py	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	tools/gyp/all.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gyp/common.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/gyp/msvs.gypi	View	1 2	1 chunk	+17 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/utils.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://codereview.chromium.org/10933125/diff/3001/tools/create_sdk.py File tools/create_sdk.py (right): https://codereview.chromium.org/10933125/diff/3001/tools/create_sdk.py#newcode115 tools/create_sdk.py:115: # TODO(dgrove) - fix this once issue 4788 ...

8 years, 3 months ago (2012-09-18 06:34:30 UTC) #2

ahe

LGTM! https://chromiumcodereview.appspot.com/10933125/diff/3001/tools/create_sdk.py File tools/create_sdk.py (right): https://chromiumcodereview.appspot.com/10933125/diff/3001/tools/create_sdk.py#newcode115 tools/create_sdk.py:115: # TODO(dgrove) - fix this once issue 4788 ...

8 years, 3 months ago (2012-09-18 07:25:23 UTC) #3

ricow1

https://chromiumcodereview.appspot.com/10933125/diff/3001/tools/create_sdk.py File tools/create_sdk.py (right): https://chromiumcodereview.appspot.com/10933125/diff/3001/tools/create_sdk.py#newcode115 tools/create_sdk.py:115: # TODO(dgrove) - fix this once issue 4788 is ...

8 years, 3 months ago (2012-09-18 07:27:41 UTC) #4

Johnni Winther

8 years, 3 months ago (2012-09-18 07:40:40 UTC) #5

https://chromiumcodereview.appspot.com/10933125/diff/3001/tools/gyp/msvs.gypi
File tools/gyp/msvs.gypi (right):

https://chromiumcodereview.appspot.com/10933125/diff/3001/tools/gyp/msvs.gypi...
tools/gyp/msvs.gypi:11: # custom msvs_configuration_attributes in
target_defaults to add them to
On 2012/09/18 07:25:23, ahe wrote:
> On 2012/09/18 06:34:31, ricow1 wrote:
> > in target_defaults? this is what we are doing right? 
> 
> It should be something like this:
> 
> Instead, specify your custom msvs_configuration_attributes in a
target_defaults
> section of a .gypi file that is explicitly included.

Done.

Expand Messages | Collapse Messages