Issue 1092653002: Fix "edit.format" to follow protocol when there is no selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1092653002: Fix "edit.format" to follow protocol when there is no selection. (Closed)

Created:
5 years, 8 months ago by Paul Berry

Modified:
5 years, 8 months ago

Reviewers:
pquitslund, Brian Wilkerson

CC:
reviews_dartlang.org, Brian Wilkerson

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Fix "edit.format" to follow protocol when there is no selection. BUG=dartbug.com/23230 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=45210

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -2 lines)			Patch
	M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View		1 chunk	+14 lines, -2 lines	0 comments	Download
	M	pkg/analysis_server/test/edit/format_test.dart	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

Note: in a future CL I will add assertions to the analysis server API code ...

5 years, 8 months ago (2015-04-16 13:49:04 UTC) #2

Paul Berry

5 years, 8 months ago (2015-04-16 14:45:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45210 (presubmit successful).