Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1092553002: Improve CssClassSet add / remove (Closed)

Created:
5 years, 8 months ago by sra1
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Improve CssClassSet add / remove Allow the 'contains' call to be removed if the result is unused. DivElement bars = new DivElement() ..classes.add('pipeline-bars'); --> t3 = document.createElement("div", null); list = t3.classList; list.contains("pipeline-bars"); list.add("pipeline-bars"); --> t3 = document.createElement("div", null); t3.classList.add("pipeline-bars"); R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=45324

Patch Set 1 : #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +14 lines, -5 lines 0 comments Download
M tools/dom/src/dart2js_CssClassSet.dart View 1 2 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sra1
5 years, 8 months ago (2015-04-21 02:54:01 UTC) #4
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1092553002/diff/40001/tools/dom/src/dart2js_CssClassSet.dart File tools/dom/src/dart2js_CssClassSet.dart (right): https://codereview.chromium.org/1092553002/diff/40001/tools/dom/src/dart2js_CssClassSet.dart#newcode230 tools/dom/src/dart2js_CssClassSet.dart:230: static bool _classListContainsBeforeAddRemove( optional minor nit: ...AddRemove => ...
5 years, 8 months ago (2015-04-21 05:07:25 UTC) #5
sra1
https://codereview.chromium.org/1092553002/diff/40001/tools/dom/src/dart2js_CssClassSet.dart File tools/dom/src/dart2js_CssClassSet.dart (right): https://codereview.chromium.org/1092553002/diff/40001/tools/dom/src/dart2js_CssClassSet.dart#newcode230 tools/dom/src/dart2js_CssClassSet.dart:230: static bool _classListContainsBeforeAddRemove( On 2015/04/21 05:07:25, Siggi Cherem (dart-lang) ...
5 years, 8 months ago (2015-04-21 19:38:08 UTC) #6
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1092553002/diff/40001/tools/dom/src/dart2js_CssClassSet.dart File tools/dom/src/dart2js_CssClassSet.dart (right): https://codereview.chromium.org/1092553002/diff/40001/tools/dom/src/dart2js_CssClassSet.dart#newcode232 tools/dom/src/dart2js_CssClassSet.dart:232: // 'throws:never' is a lie, since 'contains' will throw ...
5 years, 8 months ago (2015-04-21 22:32:50 UTC) #7
sra1
5 years, 8 months ago (2015-04-21 22:48:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:80001) manually as 45324 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698