Issue 1092473002: Never mark free list elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1092473002: Never mark free list elements. (Closed)

Created:
5 years, 8 months ago by koda

Modified:
5 years, 8 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Never mark free list elements. Avoid confusion between heap premarking and verification by introducing the invariant that FreeListElement is never marked. Also fix incorrect statement about instruction objects being allocated premarked. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45185

Patch Set 1 #

Total comments: 1

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -14 lines)			Patch
M	runtime/vm/freelist.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+3 lines, -2 lines	1 comment	Download
M	runtime/vm/verifier.cc	View	1 chunk	+17 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

https://codereview.chromium.org/1092473002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1092473002/diff/1/runtime/vm/object.cc#newcode760 runtime/vm/object.cc:760: void VisitObject(RawObject* obj) { Another question could be: Why ...

5 years, 8 months ago (2015-04-15 21:57:01 UTC) #2

koda

5 years, 8 months ago (2015-04-15 22:18:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r45185 (presubmit successful).

Expand Messages | Collapse Messages