Issue 1092153003: Support an @OnPlatform annotation.

Issue 1092153003: Support an @OnPlatform annotation. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Description

Support an @OnPlatform annotation. Closes #75 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/3d733df80f5308e3643317c1c0dedc60bc25c173

Patch Set 2 : add on_platform #

Patch Set 3 : export on_platform #

Patch Set 4 : Code review changes #

Created: 5 years, 8 months ago

	Unified diffs	Side-by-side diffs	Stats (+534 lines, -55 lines)
M	CHANGELOG.md	View	1 chunk	+7 lines, -0 lines	0 comments
M	README.md	View	1 chunk	+35 lines, -0 lines	0 comments
M	lib/src/backend/suite.dart	View	1 chunk	+1 line, -1 line	0 comments
A	lib/src/frontend/on_platform.dart	View	1 chunk	+16 lines, -0 lines	0 comments
M	lib/src/runner/loader.dart	View	2 chunks	+6 lines, -4 lines	0 comments
M	lib/src/runner/parse_metadata.dart	View	9 chunks	+197 lines, -47 lines	0 comments
M	lib/src/utils.dart	View	1 chunk	+17 lines, -0 lines	0 comments
M	lib/test.dart	View	1 chunk	+1 line, -0 lines	0 comments
M	test/backend/metadata_test.dart	View	1 chunk	+0 lines, -1 line	0 comments
M	test/runner/browser/runner_test.dart	View	2 chunks	+76 lines, -1 line	0 comments
M	test/runner/parse_metadata_test.dart	View	1 chunk	+102 lines, -0 lines	0 comments
M	test/runner/runner_test.dart	View	2 chunks	+76 lines, -1 line	0 comments

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

kevmoo

On 2015/04/21 03:02:52, nweiz wrote: Well first: ~/source/github/test.dart/ (cl1092153003)> dartanalyzer lib/src/runner/parse_metadata.dart Analyzing [lib/src/runner/parse_metadata.dart]... [warning] The ...

5 years, 8 months ago (2015-04-21 03:11:40 UTC) #2

nweiz

On 2015/04/21 03:11:40, kevmoo wrote: > On 2015/04/21 03:02:52, nweiz wrote: > > Well first: ...

5 years, 8 months ago (2015-04-21 03:12:31 UTC) #3

kevmoo

pub run test test/runner/browser/runner_test.dart -N 'with an @OnPlat' 00:13 +1 -1: with an @OnPlatform annotation ...

5 years, 8 months ago (2015-04-21 03:16:38 UTC) #4

pub run test test/runner/browser/runner_test.dart -N 'with an @OnPlat'
00:13 +1 -1: with an @OnPlatform annotation ignores non-matching Skips
  Expected: contains '+1: All tests passed!'
    Actual: 'Compiling test.dart...\n'
    'test.dart:1:2:\n'
    'Error: Cannot resolve \'OnPlatform\'.\n'
    '@OnPlatform(const {"vm": const Skip()})\n'
    ' ^^^^^^^^^^\n'
    'test.dart:1:2:\n'
    'Error: Not a compile-time constant.\n'
    '@OnPlatform(const {"vm": const Skip()})\n'
    ' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n'
    'test.dart:1:2:\n'
    'Error: Not a compile-time constant.\n'
    '@OnPlatform(const {"vm": const Skip()})\n'
    ' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n'
    'Error: Compilation failed.\n'
    '\r00:00 +0: load error                                                     
                          \r00:00 +0 -1: load error                             
                                               \n'
    '  Failed to load "test.dart": dart2js failed.\n'
    '\r00:00 +0 -1: Some tests failed.                                          
                          \n'
    ''

  package:test                                expect
  test/runner/browser/runner_test.dart 643:7  main.<fn>.<fn>

00:25 +1 -2: with an @OnPlatform annotation respects matching Timeouts
  Expected: contains 'Test timed out after 0 seconds.'
    Actual: 'Compiling test.dart...\n'
    'test.dart:1:2:\n'
    'Error: Cannot resolve \'OnPlatform\'.\n'
    '@OnPlatform(const {\n'
    ' ^^^^^^^^^^\n'
    'test.dart:1:2:\n'
    'Error: Not a compile-time constant.\n'
    '@OnPlatform(const {\n'
    ' ^^^^^^^^^^^^^^^^^^^\n'
    'test.dart:1:2:\n'
    'Error: Not a compile-time constant.\n'
    '@OnPlatform(const {\n'
    ' ^^^^^^^^^^^^^^^^^^^\n'
    'Error: Compilation failed.\n'
    '\r00:00 +0: load error                                                     
                          \r00:00 +0 -1: load error                             
                                               \n'
    '  Failed to load "test.dart": dart2js failed.\n'
    '\r00:00 +0 -1: Some tests failed.                                          
                          \n'
    ''

  package:test                                expect
  test/runner/browser/runner_test.dart 662:7  main.<fn>.<fn>

00:38 +1 -3: with an @OnPlatform annotation ignores non-matching Timeouts
  Expected: contains '+1: All tests passed!'
    Actual: 'Compiling test.dart...\n'
    'test.dart:1:2:\n'
    'Error: Cannot resolve \'OnPlatform\'.\n'
    '@OnPlatform(const {\n'
    ' ^^^^^^^^^^\n'
    'test.dart:1:2:\n'
    'Error: Not a compile-time constant.\n'
    '@OnPlatform(const {\n'
    ' ^^^^^^^^^^^^^^^^^^^\n'
    'test.dart:1:2:\n'
    'Error: Not a compile-time constant.\n'
    '@OnPlatform(const {\n'
    ' ^^^^^^^^^^^^^^^^^^^\n'
    'Error: Compilation failed.\n'
    '\r00:00 +0: load error                                                     
                          \r00:00 +0 -1: load error                             
                                               \n'
    '  Failed to load "test.dart": dart2js failed.\n'
    '\r00:00 +0 -1: Some tests failed.                                          
                          \n'
    ''

  package:test                                expect
  test/runner/browser/runner_test.dart 682:7  main.<fn>.<fn>

00:38 +1 -3: Some tests failed.

nweiz

On 2015/04/21 03:16:38, kevmoo wrote: > pub run test test/runner/browser/runner_test.dart -N 'with an @OnPlat' > ...

5 years, 8 months ago (2015-04-21 03:25:18 UTC) #5

On 2015/04/21 03:16:38, kevmoo wrote:
> pub run test test/runner/browser/runner_test.dart -N 'with an @OnPlat'
> 00:13 +1 -1: with an @OnPlatform annotation ignores non-matching Skips
>   Expected: contains '+1: All tests passed!'
>     Actual: 'Compiling test.dart...\n'
>     'test.dart:1:2:\n'
>     'Error: Cannot resolve \'OnPlatform\'.\n'
>     '@OnPlatform(const {"vm": const Skip()})\n'
>     ' ^^^^^^^^^^\n'
>     'test.dart:1:2:\n'
>     'Error: Not a compile-time constant.\n'
>     '@OnPlatform(const {"vm": const Skip()})\n'
>     ' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n'
>     'test.dart:1:2:\n'
>     'Error: Not a compile-time constant.\n'
>     '@OnPlatform(const {"vm": const Skip()})\n'
>     ' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n'
>     'Error: Compilation failed.\n'
>     '\r00:00 +0: load error                                                   
 
>                           \r00:00 +0 -1: load error                           
 
>                                                \n'
>     '  Failed to load "test.dart": dart2js failed.\n'
>     '\r00:00 +0 -1: Some tests failed.                                        
 
>                           \n'
>     ''
> 
>   package:test                                expect
>   test/runner/browser/runner_test.dart 643:7  main.<fn>.<fn>
> 
> 00:25 +1 -2: with an @OnPlatform annotation respects matching Timeouts
>   Expected: contains 'Test timed out after 0 seconds.'
>     Actual: 'Compiling test.dart...\n'
>     'test.dart:1:2:\n'
>     'Error: Cannot resolve \'OnPlatform\'.\n'
>     '@OnPlatform(const {\n'
>     ' ^^^^^^^^^^\n'
>     'test.dart:1:2:\n'
>     'Error: Not a compile-time constant.\n'
>     '@OnPlatform(const {\n'
>     ' ^^^^^^^^^^^^^^^^^^^\n'
>     'test.dart:1:2:\n'
>     'Error: Not a compile-time constant.\n'
>     '@OnPlatform(const {\n'
>     ' ^^^^^^^^^^^^^^^^^^^\n'
>     'Error: Compilation failed.\n'
>     '\r00:00 +0: load error                                                   
 
>                           \r00:00 +0 -1: load error                           
 
>                                                \n'
>     '  Failed to load "test.dart": dart2js failed.\n'
>     '\r00:00 +0 -1: Some tests failed.                                        
 
>                           \n'
>     ''
> 
>   package:test                                expect
>   test/runner/browser/runner_test.dart 662:7  main.<fn>.<fn>
> 
> 00:38 +1 -3: with an @OnPlatform annotation ignores non-matching Timeouts
>   Expected: contains '+1: All tests passed!'
>     Actual: 'Compiling test.dart...\n'
>     'test.dart:1:2:\n'
>     'Error: Cannot resolve \'OnPlatform\'.\n'
>     '@OnPlatform(const {\n'
>     ' ^^^^^^^^^^\n'
>     'test.dart:1:2:\n'
>     'Error: Not a compile-time constant.\n'
>     '@OnPlatform(const {\n'
>     ' ^^^^^^^^^^^^^^^^^^^\n'
>     'test.dart:1:2:\n'
>     'Error: Not a compile-time constant.\n'
>     '@OnPlatform(const {\n'
>     ' ^^^^^^^^^^^^^^^^^^^\n'
>     'Error: Compilation failed.\n'
>     '\r00:00 +0: load error                                                   
 
>                           \r00:00 +0 -1: load error                           
 
>                                                \n'
>     '  Failed to load "test.dart": dart2js failed.\n'
>     '\r00:00 +0 -1: Some tests failed.                                        
 
>                           \n'
>     ''
> 
>   package:test                                expect
>   test/runner/browser/runner_test.dart 682:7  main.<fn>.<fn>
> 
> 00:38 +1 -3: Some tests failed.

What version of Dart is that?

kevmoo

On 2015/04/21 03:25:18, nweiz wrote: > On 2015/04/21 03:16:38, kevmoo wrote: > > pub run ...

5 years, 8 months ago (2015-04-21 03:27:58 UTC) #6

On 2015/04/21 03:25:18, nweiz wrote:
> On 2015/04/21 03:16:38, kevmoo wrote:
> > pub run test test/runner/browser/runner_test.dart -N 'with an @OnPlat'
> > 00:13 +1 -1: with an @OnPlatform annotation ignores non-matching Skips
> >   Expected: contains '+1: All tests passed!'
> >     Actual: 'Compiling test.dart...\n'
> >     'test.dart:1:2:\n'
> >     'Error: Cannot resolve \'OnPlatform\'.\n'
> >     '@OnPlatform(const {"vm": const Skip()})\n'
> >     ' ^^^^^^^^^^\n'
> >     'test.dart:1:2:\n'
> >     'Error: Not a compile-time constant.\n'
> >     '@OnPlatform(const {"vm": const Skip()})\n'
> >     ' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n'
> >     'test.dart:1:2:\n'
> >     'Error: Not a compile-time constant.\n'
> >     '@OnPlatform(const {"vm": const Skip()})\n'
> >     ' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n'
> >     'Error: Compilation failed.\n'
> >     '\r00:00 +0: load error                                                 
 
>  
> >                           \r00:00 +0 -1: load error                         
 
>  
> >                                                \n'
> >     '  Failed to load "test.dart": dart2js failed.\n'
> >     '\r00:00 +0 -1: Some tests failed.                                      
 
>  
> >                           \n'
> >     ''
> > 
> >   package:test                                expect
> >   test/runner/browser/runner_test.dart 643:7  main.<fn>.<fn>
> > 
> > 00:25 +1 -2: with an @OnPlatform annotation respects matching Timeouts
> >   Expected: contains 'Test timed out after 0 seconds.'
> >     Actual: 'Compiling test.dart...\n'
> >     'test.dart:1:2:\n'
> >     'Error: Cannot resolve \'OnPlatform\'.\n'
> >     '@OnPlatform(const {\n'
> >     ' ^^^^^^^^^^\n'
> >     'test.dart:1:2:\n'
> >     'Error: Not a compile-time constant.\n'
> >     '@OnPlatform(const {\n'
> >     ' ^^^^^^^^^^^^^^^^^^^\n'
> >     'test.dart:1:2:\n'
> >     'Error: Not a compile-time constant.\n'
> >     '@OnPlatform(const {\n'
> >     ' ^^^^^^^^^^^^^^^^^^^\n'
> >     'Error: Compilation failed.\n'
> >     '\r00:00 +0: load error                                                 
 
>  
> >                           \r00:00 +0 -1: load error                         
 
>  
> >                                                \n'
> >     '  Failed to load "test.dart": dart2js failed.\n'
> >     '\r00:00 +0 -1: Some tests failed.                                      
 
>  
> >                           \n'
> >     ''
> > 
> >   package:test                                expect
> >   test/runner/browser/runner_test.dart 662:7  main.<fn>.<fn>
> > 
> > 00:38 +1 -3: with an @OnPlatform annotation ignores non-matching Timeouts
> >   Expected: contains '+1: All tests passed!'
> >     Actual: 'Compiling test.dart...\n'
> >     'test.dart:1:2:\n'
> >     'Error: Cannot resolve \'OnPlatform\'.\n'
> >     '@OnPlatform(const {\n'
> >     ' ^^^^^^^^^^\n'
> >     'test.dart:1:2:\n'
> >     'Error: Not a compile-time constant.\n'
> >     '@OnPlatform(const {\n'
> >     ' ^^^^^^^^^^^^^^^^^^^\n'
> >     'test.dart:1:2:\n'
> >     'Error: Not a compile-time constant.\n'
> >     '@OnPlatform(const {\n'
> >     ' ^^^^^^^^^^^^^^^^^^^\n'
> >     'Error: Compilation failed.\n'
> >     '\r00:00 +0: load error                                                 
 
>  
> >                           \r00:00 +0 -1: load error                         
 
>  
> >                                                \n'
> >     '  Failed to load "test.dart": dart2js failed.\n'
> >     '\r00:00 +0 -1: Some tests failed.                                      
 
>  
> >                           \n'
> >     ''
> > 
> >   package:test                                expect
> >   test/runner/browser/runner_test.dart 682:7  main.<fn>.<fn>
> > 
> > 00:38 +1 -3: Some tests failed.
> 
> What version of Dart is that?

1.10.0-dev.1.5

Give me a sec to build bleeding edge...

kevmoo

LGTM with tiny comments https://codereview.chromium.org/1092153003/diff/1/lib/src/utils.dart File lib/src/utils.dart (right): https://codereview.chromium.org/1092153003/diff/1/lib/src/utils.dart#newcode56 lib/src/utils.dart:56: E first; both could be ...

5 years, 8 months ago (2015-04-21 03:48:38 UTC) #7

nweiz

https://codereview.chromium.org/1092153003/diff/1/lib/src/utils.dart File lib/src/utils.dart (right): https://codereview.chromium.org/1092153003/diff/1/lib/src/utils.dart#newcode56 lib/src/utils.dart:56: E first; On 2015/04/21 03:48:38, kevmoo wrote: > both ...

5 years, 8 months ago (2015-04-21 20:01:04 UTC) #9

nweiz

5 years, 8 months ago (2015-04-21 20:01:17 UTC) #10

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
3d733df80f5308e3643317c1c0dedc60bc25c173 (presubmit successful).

Expand Messages | Collapse Messages