Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 1092053003: Don’t search scope of top-level class twice (Closed)

Created:
5 years, 8 months ago by hausner
Modified:
5 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Don’t search scope of top-level class twice When resolving an identifier in top-level code, we don’t need to search the class scope. That scope is searched again when resolving the identifier in the library scope. Sadly, the change makes no measurable difference. It’s just a drop in the bucket. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=45249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M runtime/vm/parser.cc View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 8 months ago (2015-04-17 17:17:06 UTC) #2
regis
lgtm
5 years, 8 months ago (2015-04-17 17:19:42 UTC) #3
hausner
5 years, 8 months ago (2015-04-17 18:08:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r45249 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698