Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 10919290: Issue 3476. Final variables don't have to have constant initializers (Closed)

Created:
8 years, 3 months ago by scheglov
Modified:
8 years, 3 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 3476. Final variables don't have to have constant initializers http://code.google.com/p/dart/issues/detail?id=3476 R=jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -29 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java View 4 chunks +4 lines, -11 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java View 2 chunks +25 lines, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/directory_impl.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/co19/co19-compiler.status View 2 chunks +0 lines, -6 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 3 months ago (2012-09-14 12:50:10 UTC) #1
jwren
8 years, 3 months ago (2012-09-14 12:59:55 UTC) #2
On 2012/09/14 12:50:10, scheglov wrote:

LGTM

Powered by Google App Engine
This is Rietveld 408576698