Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 10919263: Re-land r12289. (Closed)

Created:
8 years, 3 months ago by kasperl
Modified:
8 years, 3 months ago
Reviewers:
hausner, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Re-land r12289. Looks like Johnni has fixed the dartdoc issues. R=iposva@google.com,hausner@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -52 lines) Patch
M runtime/vm/ast.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 18 chunks +23 lines, -40 lines 0 comments Download
M tests/co19/co19-runtime.status View 4 chunks +16 lines, -5 lines 0 comments Download
M tests/language/language.status View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
8 years, 3 months ago (2012-09-13 11:13:51 UTC) #1
Ivan Posva
Rubberstamp: LGTM -ip
8 years, 3 months ago (2012-09-13 12:34:44 UTC) #2
hausner
8 years, 3 months ago (2012-09-13 16:29:28 UTC) #3
Great, thank you for doing this. LGTM.

Powered by Google App Engine
This is Rietveld 408576698