Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1091903002: Move DomProxyMixin to this package (Closed)

Created:
5 years, 8 months ago by jakemac
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-components.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : move into custom_element_proxy.dart and rename CustomElementProxyMixin #

Patch Set 3 : add example to changelog #

Patch Set 4 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -8 lines) Patch
M CHANGELOG.md View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M lib/build/mirrors_remover.dart View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M lib/custom_element_proxy.dart View 1 2 chunks +15 lines, -0 lines 0 comments Download
M lib/src/init.dart View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jakemac
5 years, 8 months ago (2015-04-16 22:43:04 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1091903002/diff/1/lib/web_components.dart File lib/web_components.dart (right): https://codereview.chromium.org/1091903002/diff/1/lib/web_components.dart#newcode8 lib/web_components.dart:8: export 'src/dom_proxy_mixin.dart'; to match the name of the ...
5 years, 8 months ago (2015-04-16 22:48:09 UTC) #3
Siggi Cherem (dart-lang)
On 2015/04/16 22:48:09, Siggi Cherem (dart-lang) wrote: > lgtm > > https://codereview.chromium.org/1091903002/diff/1/lib/web_components.dart > File lib/web_components.dart ...
5 years, 8 months ago (2015-04-16 22:48:22 UTC) #4
jakemac
https://codereview.chromium.org/1091903002/diff/1/lib/web_components.dart File lib/web_components.dart (right): https://codereview.chromium.org/1091903002/diff/1/lib/web_components.dart#newcode8 lib/web_components.dart:8: export 'src/dom_proxy_mixin.dart'; On 2015/04/16 22:48:09, Siggi Cherem (dart-lang) wrote: ...
5 years, 8 months ago (2015-04-17 16:25:05 UTC) #5
jakemac
5 years, 8 months ago (2015-04-17 17:54:09 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
56359050f819338ca417e110615e9156b72ace72 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698