Update language tests to new optional parameter syntax and semantics.

Update language tests to new optional parameter syntax and semantics.
Committed: https://code.google.com/p/dart/source/detail?r=12415

[regis, 2012-09-15 23:01:10]

TBR

[ngeoffray, 2012-09-16 08:35:26]

LGTM, but

https://codereview.chromium.org/10918261/diff/1/tests/language/argument_defin...
File tests/language/argument_definition2_test.dart (right):

https://codereview.chromium.org/10918261/diff/1/tests/language/argument_defin...
tests/language/argument_definition2_test.dart:4: //
VMOptions=--reject_named_argument_as_positional
This won't work for dart2js, could you change the test instead to avoid adding
this? Or change test.py to always pass that option from now on?

[regis, 2012-09-17 17:16:42]

https://codereview.chromium.org/10918261/diff/1/tests/language/argument_defin...
File tests/language/argument_definition2_test.dart (right):

https://codereview.chromium.org/10918261/diff/1/tests/language/argument_defin...
tests/language/argument_definition2_test.dart:4: //
VMOptions=--reject_named_argument_as_positional
On 2012/09/16 08:35:27, ngeoffray wrote:
> This won't work for dart2js, could you change the test instead to avoid adding
> this? Or change test.py to always pass that option from now on?

I notice now that this particular test did not need this change, since it runs
fine under both the old and new semantics. However, there are other tests that I
fixed in this cl that only run under the new semantics.

Unfortunately, this is still too early to run all tests under the new semantics,
because of some issues in the corelib (e.g. Date constructor). So I cannot yet
pass that flag from test.py.

I suggest that we leave it as is until this becomes an issue for dart2js. At
that time, I suspect that the core lib will be updated so that all tests can be
run under the new semantics. We can then pass the flag in test.py and remove
these VMOptions directives in the tests.

Would that work for you?

Thanks!

[ngeoffray, 2012-09-21 07:12:32]

https://codereview.chromium.org/10918261/diff/1/tests/language/argument_defin...
File tests/language/argument_definition2_test.dart (right):

https://codereview.chromium.org/10918261/diff/1/tests/language/argument_defin...
tests/language/argument_definition2_test.dart:4: //
VMOptions=--reject_named_argument_as_positional
On 2012/09/17 17:16:42, regis wrote:
> On 2012/09/16 08:35:27, ngeoffray wrote:
> > This won't work for dart2js, could you change the test instead to avoid
adding
> > this? Or change test.py to always pass that option from now on?
> 
> I notice now that this particular test did not need this change, since it runs
> fine under both the old and new semantics. However, there are other tests that
I
> fixed in this cl that only run under the new semantics.
> 
> Unfortunately, this is still too early to run all tests under the new
semantics,
> because of some issues in the corelib (e.g. Date constructor). So I cannot yet
> pass that flag from test.py.
> 
> I suggest that we leave it as is until this becomes an issue for dart2js. At
> that time, I suspect that the core lib will be updated so that all tests can
be
> run under the new semantics. We can then pass the flag in test.py and remove
> these VMOptions directives in the tests.
> 
> Would that work for you?

No problem, let's do that and hope we can remove this flag ASAP.

> 
> Thanks!