Issue 10918247: Issue 5084. Report error if a type name appears multiple times in an implements clause

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10918247: Issue 5084. Report error if a type name appears multiple times in an implements clause (Closed)

Created:
8 years, 3 months ago by scheglov

Modified:
8 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 5084. Report error if a type name appears multiple times in an implements clause http://code.google.com/p/dart/issues/detail?id=5084 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12391

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't report duplicates for unresolved types #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -9 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java	View	1	2 chunks	+15 lines, -4 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language.status	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 3 months ago (2012-09-14 15:07:36 UTC) #2

LGTM after one possible change

https://codereview.chromium.org/10918247/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java
(right):

https://codereview.chromium.org/10918247/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java:100: if
(seenImplement.contains(intType)) {
I think we want to test here that it isn't dynamic so that we don't warn for
something like "implement A, B" where both A and B are unknown types.

https://codereview.chromium.org/10918247/diff/1/compiler/javatests/com/google...
File
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
(right):

https://codereview.chromium.org/10918247/diff/1/compiler/javatests/com/google...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java:4792:
public void test_duplicateSuperInterface_okInInterfaceExtends() throws Exception
{
I'm not sure I'd bother to test the interface case since it will be going away
within the next couple of weeks, but I don't have a problem with leaving it
until then.

Expand Messages | Collapse Messages