Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 10918213: - Move double and int implementations into dart:core and make them private. (Closed)

Created:
8 years, 3 months ago by Ivan Posva
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Move double and int implementations into dart:core and make them private. Committed: https://code.google.com/p/dart/source/detail?r=12330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -107 lines) Patch
M lib/double.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M lib/integers.dart View 5 chunks +14 lines, -14 lines 0 comments Download
M lib/lib_impl_sources.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M lib/lib_sources.gypi View 1 chunk +5 lines, -1 line 0 comments Download
M vm/intermediate_language.h View 1 chunk +2 lines, -2 lines 0 comments Download
M vm/intrinsifier.h View 1 chunk +40 lines, -40 lines 0 comments Download
M vm/object.cc View 3 chunks +31 lines, -33 lines 0 comments Download
M vm/symbols.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ivan Posva
8 years, 3 months ago (2012-09-13 13:27:51 UTC) #1
Mads Ager (google)
8 years, 3 months ago (2012-09-13 13:33:52 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698